Skip to content

OAuth login [WIP] - #36

Open
stefankoegl wants to merge 3 commits into
masterfrom
oauth-login
Open

OAuth login [WIP]#36
stefankoegl wants to merge 3 commits into
masterfrom
oauth-login

Conversation

@stefankoegl

@stefankoegl stefankoegl commented Aug 21, 2016 •
edited
Loading

Copy link
Copy Markdown
Member

Decouple gpodder.net's authentication from the application itself. This would allow other applications (eg podcast clients) to authenticate against the same source, and would also help to decouple gpodder.net into smaller components (eg a directory, subscription service, etc).

mygpo-auth functional OAuth service.

TODO

  • implement registration flow
  • move / copy users to an instance of mygpo-auth
  • Tests
  • more?

@coveralls

coveralls commented Jul 4, 2017 •
edited
Loading

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.03%) to 46.431% when pulling 2e4a931 on oauth-login into 5cd52a5 on master.

@gpodder gpodder deleted a comment from coveralls Aug 6, 2017
@gpodder gpodder deleted a comment from coveralls Aug 6, 2017
@stefankoegl stefankoegl mentioned this pull request Sep 2, 2018
Closed
@stefankoegl stefankoegl changed the title OAuth login OAuth login [WIP] Feb 2, 2020
@sschyu sschyu self-assigned this Feb 28, 2020
@sschyu
sschyu self-requested a review February 28, 2020 02:28
@sschyu sschyu added the auth label Feb 28, 2020
@sschyu

sschyu commented Mar 20, 2020

Copy link
Copy Markdown
Contributor

The mygpo-auth implements OAuth by itself. I was wondering why not use a library like oauthlib? Security concerns could be delegated to the library instead of us.

I plan to introduce DRF in the future. I think the oauthlib integration could be helpful.

@stefankoegl

stefankoegl commented Apr 4, 2020

Copy link
Copy Markdown
Member Author

The mygpo-auth implements OAuth by itself. I was wondering why not use a library like oauthlib?

To be honest, I can't remember.

Security concerns could be delegated to the library instead of us.

Absolutely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sschyu sschyu Awaiting requested review from sschyu

Assignees

@sschyu sschyu

Labels

auth

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stefankoegl @coveralls @sschyu @clementsjosh